Remove buggy ctrl+x to cut entity to paste it right away #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… entity is removed from the DOM, some components like position/rotation/scale reset to their default value
vincentfretin
force-pushed
the
remove-buggy-cut-entity
branch
from
8886e79
to
88e84ca
Compare
|
I found it weird we had "supr" here, in English keyboard it's Delete right. On my French keyboard, it's Suppr (two p) stands for Supprimer. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove buggy ctrl+x to cut entity to paste it right away, because the entity is removed from the DOM, some components like position/rotation/scale reset to their default value.
If we really want to fix it, we should really keep an object representation of the deleted entity so that it could use createEntity(definition) when we press ctrl+v in this case instead of cloneEntity, but we currently don't support creating children on createEntity.
To be honest, I don't think it's worth to keep that feature, and I really don't understand what was the purpose of it in the first place.
We could keep it as way to remove an entity without confirmation, in this case we remove the
AFRAME.INSPECTOR.entityToCopyassigment here and we reflect that purpose in the help modal. Thoughts?Note that the ctrl+x,c,v shortcuts only worked on Windows since a long time, and were fixed for Linux and macOS only recently #729