Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata relation rules #393

Open
3 of 27 tasks
hibadjebabria169 opened this issue Feb 6, 2023 · 3 comments
Open
3 of 27 tasks

Add metadata relation rules #393

hibadjebabria169 opened this issue Feb 6, 2023 · 3 comments
Labels
enhancement metadata Issues related to metadata edition/curation

Comments

@hibadjebabria169
Copy link

hibadjebabria169 commented Feb 6, 2023

Issue related to the verification of the rules between the properties:

Notes :

let : version n-1 = previous version, n = current version

  • If status=retired => deprecated=true.
  • If status(n)=retired then status(n-i)=retired
  • curatedBy shouldn't be equal to hasCreator .
  • versionIRI shouldn't be equal to URI.
  • URI shouldn't be equal to identifier.
  • New submission creation must make previous submission deprecated. => All deprecated values of submission before the latest one must be = true
  • If deprecated = true then validity date should be before or equal to day date .
  • If validity date is before the day date then Deprecated=true
  • Modification date must always be after or equal to Creation date.
  • Modification date of new submission must be after modiifcation date of previous submission
  • Submission date, should be updated every time there's a new submission but always be after or equal to Modification date.
  • Curation date must always be after or equal to Creation date.
  • New submission creation must make validity date of previous submission the modification date of new submission (or submission date if no modification date is available).
  • New submission creation has Prior Version the id of the previous submission
  • New submission creation Has Version an array of all previous submissions
  • New submission creation must make previous version deprecated
  • If an ontology o has for view an ontology v then has part(o)=v
  • If an ontology o has for view an ontology v then is part of (v)=o
  • If isAlignedTo(o1)=o2 then isAlignedTo(o1)=o2
  • If generalises(o1)=o2 then explanationEvolution(o2)=o1
  • If translationOfWork(o1)=o2 then workTranslation(o2)=o1
  • If hasDisparateModelling(o1)=o2 then hasDisparateModelling(o2)=o1
  • If comesFromTheSameDomain(o1)=o2 then comesFromTheSameDomain(o2)=o1
  • If useImports(o1)=o2 then usedBy(o2)=o1
  • If ontologyRelatedTo(o1)=o2 then ontologyRelatedTo(o2)=o1
  • If similarToo(o1)=o2 then similarToo(o2)=1
  • other identifier value should be different from the URI of the concerned ontology
@jonquet

This comment was marked as outdated.

@syphax-bouazzouni syphax-bouazzouni added the project managment issues used as development tasks in our projects label Feb 16, 2023
@syphax-bouazzouni
Copy link
Contributor

syphax-bouazzouni commented Feb 20, 2023

I reviewed these rules and referenced them here https://docs.google.com/spreadsheets/d/1DuHmz0G6NrLB6jXuU040Nf-ZcDIyOjtt7AT1-NSgWHQ/edit?usp=sharing. Some of them are dedicated validators and others are generic ones.

The new validators to implement are

Generic ones

  • implement superior_equal_to_<property> validator ontoportal-lirmm/goo#19 for

    • Modification date must always be after or equal to Creation date.
    • Modification date of new submission must be after modiifcation date of previous submission
    • Submission date, should be updated every time there's a new submission but always be after or equal to Modification date.
    • New submission creation must make validity date of previous submission the modification date of new submission (or submission date if no modification date is available).
    • Curation date must always be after or equal to Creation date.
  • implement distinct_of_<property> validator ontoportal-lirmm/goo#21 for

    • curatedBy shouldn't be equal to hasCreator .
    • versionIRI shouldn't be equal to URI.
    • URI shouldn't be equal to identifier.
    • other identifier value should be different from the URI of the concerned ontology
  • email_validator for mailing-list

Submission specific

Validators

  • modification_date_previous_align for

    • Modification date of new submission must be after modification date of previous submission
  • deprecated_retired_align for

    • If status=retired => deprecated=true.
  • validity_date_retired_align for

    • If deprecated = true then validity date should be before or equal to day date .
    • If validity date is before the day date then Deprecated=true
  • include_ontology_views for

    • If an ontology o has for view an ontology v then has part(o)=v

Update Callback

  • include_previous_submission for

    • New submission creation has Prior Version the id of the previous submission
  • deprecate_previous_submissions for

    • New submission creation must make the previous submissions deprecated. => All deprecated values of submission before the latest one must be = true
  • retired_previous_align for

    • if status(n) = retired => status(n-1) = retired
  • ontology_inverse_of_callback for

    • If useImports(o1)=o2 then usedBy(o2)=o1
    • translationOfWork(o1)=o2 then workTranslation(o2)=o1
    • generalises(o1)=o2 then explanationEvolution(o2)=o1
  • enforce_symmetric_ontologies

    • If ontologyRelatedTo(o1)=o2 then ontologyRelatedTo(o2)=o1
    • If similarToo(o1)=o2 then similarToo(o2)=1
    • if isAlignedTo(o1)=o2 then isAlignedTo(o1)=o2
  • update_submissions_has_part

    • If an ontology o has for view an ontology v then has part(o)=v

@syphax-bouazzouni
Copy link
Contributor

  • New submission creation must make the previous version deprecated - error did not show - validator not called
  • New submission creation must make the validity date of the previous submission the modification date of the new submission (or submission date if no modification date is available). the error did not show - the validator was not called
  • New submission creation has Prior Version the id of the previous submission - error not showed - validator not called
    Source: https://docs.google.com/spreadsheets/d/1lEdrxJKKOJYbSYH_Ptzu2dUliHAKcFTirrw8vs9Hcuk/edit#gid=713725591&fvid=1197518333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement metadata Issues related to metadata edition/curation
Projects
None yet
Development

No branches or pull requests

3 participants