Warning if no iterations or validation set specified.

Closes #104.
aigamedev · Nov 17, 2015 · 58fcb3c · 58fcb3c
1 parent fc9142b
commit 58fcb3c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/sknn/mlp.py b/sknn/mlp.py
@@ -119,6 +119,9 @@ def _reshape(self, X, y=None):
         return X, y
 
     def _train(self, X, y):
+        assert self.n_iter or self.valid_set,\
+            "Neither n_iter nor valid_set were specified; training would loop forever."
+
         best_train_error, best_valid_error = float("inf"), float("inf")
         stable = 0
 

diff --git a/sknn/tests/test_training.py b/sknn/tests/test_training.py
@@ -33,6 +33,11 @@ def test_FitAutomaticValidation(self):
                     valid_size=0.25)
 
         self.nn._fit(a_in, a_out)
+
+    def test_TrainingInfinite(self):
+        a_in, a_out = numpy.zeros((8,16)), numpy.zeros((8,4))
+        self.nn = MLP(layers=[L("Linear")])
+        assert_raises(AssertionError, self.nn._fit, a_in, a_out)
 
 
 class TestCustomLogging(unittest.TestCase):