Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps: devcontainer update to use new docker stack #6139

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Sep 26, 2023

@unkcpz unkcpz requested a review from ltalirz September 26, 2023 13:42
@unkcpz unkcpz force-pushed the fix/xx/devcontainer-new-docker branch from 5ccca89 to 86e6917 Compare September 26, 2023 13:43
@unkcpz unkcpz force-pushed the fix/xx/devcontainer-new-docker branch from 4b93534 to b02c557 Compare September 26, 2023 14:11
@unkcpz unkcpz requested a review from sphuber September 27, 2023 13:26
@unkcpz
Copy link
Member Author

unkcpz commented Sep 27, 2023

After this one, can we make a patch release with all new docker stack implementations (#6131, #6129, #6127, #6119, #6080)? @sphuber

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @unkcpz

@sphuber sphuber merged commit 61828e2 into aiidateam:main Sep 27, 2023
19 checks passed
@sphuber
Copy link
Contributor

sphuber commented Sep 27, 2023

After this one, can we make a patch release with all new docker stack implementations (#6131, #6129, #6127, #6119, #6080)? @sphuber

I think we are getting close to being able to release v2.5.0. Would it be ok to wait a bit and ship it with this minor release?

@unkcpz unkcpz deleted the fix/xx/devcontainer-new-docker branch September 28, 2023 07:13
@unkcpz
Copy link
Member Author

unkcpz commented Sep 28, 2023

The only concern I have is these four lines haven't been run before and they are supposed to give the right tag to the image when making the release to dockerhub.

type=match,pattern=v(\d+\.\d+.\d+),group=1
type=raw,value={{tag}},enable=${{ startsWith(github.ref, 'refs/tags/v') }}
type=raw,value=python-${{ env.PYTHON_VERSION }},enable=${{ startsWith(github.ref, 'refs/tags/v') }}
type=raw,value=postgresql-${{ env.PGSQL_VERSION }},enable=${{ startsWith(github.ref, 'refs/tags/v') }}

Can you give it double-check the matching pattern is all good? I am totally fine with v2.5.0.

unkcpz added a commit that referenced this pull request Sep 28, 2023
Amendment to #6139, for unknown reason, docker pull is failed for docker.io on this repository. Using the docker registry ghcr.io works fine.
@sphuber
Copy link
Contributor

sphuber commented Oct 3, 2023

@unkcpz I am not familiar with the syntax for those acxtions, but our tags do follow the pattern pattern=v(\d+\.\d+.\d+), e.g., v2.5.1. So think that looks okay

sphuber pushed a commit that referenced this pull request Nov 14, 2023
sphuber pushed a commit that referenced this pull request Nov 14, 2023
Amendment to #6139, for unknown reason, docker pull is failed for
docker.io on this repository. Using the docker registry ghcr.io works
fine.

Cherry-pick: 8d8b41d
sphuber pushed a commit that referenced this pull request Nov 15, 2023
sphuber pushed a commit that referenced this pull request Nov 15, 2023
Amendment to #6139, for unknown reason, docker pull is failed for
docker.io on this repository. Using the docker registry ghcr.io works
fine.

Cherry-pick: 8d8b41d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants