Docker: folder for scripts run in container startup stages #6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
force-pushed
the
fea/x/run-parts-s6-overlay-services
branch
from
559881d
to
36bf9fa
Compare
for more information, see https://pre-commit.ci
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6170 +/- ##
=======================================
Coverage 79.77% 79.77%
=======================================
Files 547 547
Lines 40131 40131
=======================================
Hits 32010 32010
Misses 8121 8121 ☔ View full report in Codecov by Sentry. |
sphuber
approved these changes
Nov 9, 2023
sphuber
pushed a commit
that referenced
this pull request
Nov 14, 2023
…n start (#6170) In order to simplify the implementation of using the `aiida-core` image as the base for customized images, the `run-before-daemon-start` and `run-after-daemon-start` script folders are created. Any executables in these two folders will be executed before and after the AiiDA daemon is started in the container, respectively. The standard linux `run-parts` tool is used to scan these folders for files, which are run in the lexical sort order of their names, according to the C/POSIX locale character collation rules Cherry-pick: 5fe6f4f
sphuber
pushed a commit
that referenced
this pull request
Nov 15, 2023
…n start (#6170) In order to simplify the implementation of using the `aiida-core` image as the base for customized images, the `run-before-daemon-start` and `run-after-daemon-start` script folders are created. Any executables in these two folders will be executed before and after the AiiDA daemon is started in the container, respectively. The standard linux `run-parts` tool is used to scan these folders for files, which are run in the lexical sort order of their names, according to the C/POSIX locale character collation rules Cherry-pick: 5fe6f4f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify the implementation of using aiida-core image as the base image to construct customized images, the
run-before-daemon-startandrun-after-daemon-startscript folders are created. The executables in these two folders will run before/after the aiida daemon start in the container respectively.The standard linux
run-partstool is used to scan the folder and files are run in the lexical sort order (according to the C/POSIX locale character collation rules) of their names.With this change, the customized image construction can be simplified, see aiidateam/aiida-quantumespresso@58e074a for the different before and after this change.