Use aliases when handling response_fields #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #159 +/- ##
===========================================
+ Coverage 90.59% 92.23% +1.64%
===========================================
Files 28 28
Lines 1095 1095
===========================================
+ Hits 992 1010 +18
+ Misses 103 85 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
CasperWA
force-pushed
the
fix_149_157_properly-handle-provider-specific-fields
branch
2 times, most recently
from
c976f93
to
4ab6c11
Compare
New tests for `response_fields` to ensure provider-specific fields are handled as intended.
This parameter is deprecated as of v1.5.0.
CasperWA
force-pushed
the
fix_149_157_properly-handle-provider-specific-fields
branch
from
4ab6c11
to
61ed26c
Compare
CasperWA
deleted the
fix_149_157_properly-handle-provider-specific-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149.
Fixes #157.
When handling
response_fields, the dictionary created from the entry pydantic model is created using aliases, i.e., the provider-specific prefix is added correctly toctime(and future provider-specific fields).This ensures the resulting entries are correctly presented when
response_fieldsis used.As a note, there are some optimizations that should be possible when Materials-Consortia/optimade-python-tools#560 has been merged and released.