Decorator @cached creates cache with the Cache() factory #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* See aio-libs#473: Deprecate using cache specific constructors * aio-libs#473 * `Cache` class was introduced as a proxy for instantiating the different backends. There should be only one way of doing things and `Cache` is the preferred way of doing that so will deprecate the others. * This is now applied to `cached._get_cache()`
|
Hi, do you have an feedback for this PR? |
|
As mentioned in that issue, doesn't look like the deprecation has actually happened yet. But, might as well update this. |
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 36 36
Lines 3560 3560
Branches 447 447
=======================================
Hits 3546 3546
Misses 12 12
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
: Deprecate using cache specific constructors* Deprecate using cache specific constructors #473Cacheclass was introduced as a proxy for instantiating the differentbackends. There should be only one way of doing things and
Cacheisthe preferred way of doing that so will deprecate the others.
cached._get_cache()What do these changes do?
Decorator
@cachedcreates cache with theCache()factory constructor,instead of the cache-specific constructor.
Are there changes in behavior for the user?
This should be invisible to the end user.
Related issue number
#473: Deprecate using cache specific constructors
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.