Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add addr_to_addr_info util for converting addr to addr_infos #27

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 11, 2023

create_connection usually wants one local_addr, but we support multiple because internally cpython does as well so as long as they are in addr_info format so we need a util for easy conversions.

# Convert a local_addr to local_addr_infos
local_addr_infos = addr_to_addr_infos(("127.0.0.1",0))

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7e5df1) 100.00% compared to head (dbb3099) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          128       148   +20     
  Branches        36        40    +4     
=========================================
+ Hits           128       148   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review December 11, 2023 04:20
@bdraco bdraco merged commit 2e25a98 into main Dec 11, 2023
19 of 20 checks passed
@bdraco bdraco deleted the addr_infos branch December 11, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant