Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid passing loop to staggered.staggered_race #94

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 26, 2024

What do these changes do?

remove loop param from call to staggered.staggered_race

ref aio-libs/aiohttp#8599 (comment)
ref python/cpython#124309
ref python/cpython#124639
ref python/cpython#124390
ref python/cpython#124574
ref python/cpython#124573

Are there changes in behavior for the user?

no

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (097c9fa) to head (4bab4ca).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          160       160           
  Branches        43        43           
=========================================
  Hits           160       160           
Flag Coverage Δ
99.37% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 5f80b79 into main Sep 26, 2024
27 of 28 checks passed
@bdraco bdraco deleted the drop_loop branch September 26, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant