Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy staggered from standard lib for python 3.12+ #95

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 27, 2024

asyncio.staggered is not meant to be a public API per python/cpython#124639 (comment)

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5f80b79) to head (71b3ce6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         6    +2     
  Lines          160       198   +38     
  Branches        43        45    +2     
=========================================
+ Hits           160       198   +38     
Flag Coverage Δ
98.98% <97.43%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Sep 27, 2024

Works fine on 3.12 production systems

@bdraco bdraco marked this pull request as ready for review September 27, 2024 00:52
@bdraco bdraco merged commit c5a4023 into main Sep 27, 2024
28 checks passed
@bdraco bdraco deleted the copy_staggered branch September 27, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant