Redirects for HEAD requests should use HEAD #1146

catlee · 2016-09-09T14:48:22Z

Long story short

I'm trying to do a HEAD request to a service that returns a 303 redirect. aiohttp then does a full GET on the new location.

aiohttp should instead do a HEAD on the new URL.

aiohttp does a GET on the new URL

The code responsible is here: https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/client.py#L228
This references this PR from the requests library: https://github.com/kennethreitz/requests/pull/269/files. However, the requests library is preserving the HEAD method for subsequent requests.

asvetlov · 2016-09-09T15:04:11Z

Makes sense.
Would you provide a fix?

Fixes: #1146

lock · 2019-10-29T07:02:44Z

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

asvetlov added bug client labels Sep 9, 2016

catlee pushed a commit to catlee/aiohttp that referenced this issue Sep 9, 2016

Fix redirects for HEAD requests.

baaf9d3

Fixes: aio-libs#1146

catlee mentioned this issue Sep 9, 2016

Fix redirects for HEAD requests. #1147

Merged

3 tasks

asvetlov closed this as completed in #1147 Sep 10, 2016

asvetlov pushed a commit that referenced this issue Sep 10, 2016

Fix redirects for HEAD requests. (#1147)

118826c

Fixes: #1146

aio-libs-bot mentioned this issue Nov 15, 2018

redirects? #3390

Closed

lock bot added the outdated label Oct 29, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019