use UTF-8 as the default encoding for multipart text parts #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurdarcet
force-pushed
the
default-enc-multipart
branch
from
e61fab2
to
faa8c4e
Compare
Current coverage is 98.85% (diff: 100%)@@ master #1484 diff @@
==========================================
Files 30 30
Lines 6984 6984
Methods 0 0
Messages 0 0
Branches 1163 1163
==========================================
Hits 6904 6904
Misses 40 40
Partials 40 40
|
|
Sounds reasonable |
|
It's good to see more UTF-8 defaults around (: Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some tests on Chrome, it seems in multipart/form-data bodies, regular field=value parts are encoded using utf-8, not latin1
https://www.w3.org/TR/html5/forms.html#multipart/form-data-encoding-algorithm
https://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#dom-xmlhttprequest-send