-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing for web_exceptions #3284
Merged
asvetlov
merged 5 commits into
aio-libs:master
from
kornicameister:typing_web_exceptions
Sep 24, 2018
Merged
Add typing for web_exceptions #3284
asvetlov
merged 5 commits into
aio-libs:master
from
kornicameister:typing_web_exceptions
Sep 24, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3284 +/- ##
==========================================
- Coverage 98.03% 97.99% -0.04%
==========================================
Files 43 43
Lines 7894 7896 +2
Branches 1354 1354
==========================================
- Hits 7739 7738 -1
- Misses 63 65 +2
- Partials 92 93 +1
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Sep 24, 2018
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds typings for the web_exceptions as the next step for #1749
Are there changes in behavior for the user?
None, just typings
Related issue number
partially #1749
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.