Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #3644: PY38: web_protocol.RequestHandler mismatch _keepalive field with __slots__ #3727

Merged
merged 2 commits into from
May 6, 2019
Merged

Fix issue #3644: PY38: web_protocol.RequestHandler mismatch _keepalive field with __slots__ #3727

merged 2 commits into from
May 6, 2019

Conversation

atemate
Copy link
Contributor

@atemate atemate commented May 6, 2019 •
edited
Loading

What do these changes do?

Fix issue #3644

Are there changes in behavior for the user?

No, only fixes work on Python 3.8

Related issue number

#3644

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
    • will be checked by CI tests on Python 3.8 (to-do)
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@atemate atemate requested a review from asvetlov as a code owner May 6, 2019 14:05
asvetlov
asvetlov approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asvetlov asvetlov merged commit bfb99eb into aio-libs:master May 6, 2019
@asvetlov
Copy link
Member

asvetlov commented May 6, 2019

Thanks!

asvetlov pushed a commit that referenced this pull request May 6, 2019
@asvetlov
[3.5] Fix issue #3644: PY38: web_protocol.RequestHandler mismatch _ke…
ff1c9de 
…epalive field with __slots__ (#3727)

(cherry picked from commit bfb99eb)

Co-authored-by: Artem Yushkovskiy <artem.yushkovskiy@neuromation.io>
@atemate atemate deleted the ay/fix-keepalive-slots-py38-issue3644 branch May 6, 2019 17:21
@atemate atemate mentioned this pull request May 6, 2019
Merged
asvetlov pushed a commit that referenced this pull request May 8, 2019
@asvetlov
[3.5] [3.5] Fix issue #3644: PY38: web_protocol.RequestHandler mismat…
9509fd2 
…ch _keepalive field with __slots__ (#3727) (#3731)

(cherry picked from commit bfb99eb)

Co-authored-by: Artem Yushkovskiy <artem.yushkovskiy@neuromation.io>
(cherry picked from commit ff1c9de)

Co-authored-by: Artem Yushkovskiy <artem.yushkovskiy@neuromation.io>
asvetlov added a commit that referenced this pull request May 8, 2019
@asvetlov
[3.5] Fix issue #3644: PY38: web_protocol.RequestHandler mismatch _ke…
e1ed4d7 
…epalive field with __slots__ (#3727) (#3729)

(cherry picked from commit bfb99eb)

Co-authored-by: Artem Yushkovskiy <artem.yushkovskiy@neuromation.io>
@asvetlov asvetlov mentioned this pull request May 13, 2019
Closed
@lock lock bot added the outdated label May 5, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atemate @asvetlov