Implement web.run_app utility function #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else: | ||
| port = 8443 | ||
|
|
||
| if loop is None: |
There was a problem hiding this comment.
Is an explicit loop parameter necessary -- Wouldn't loop = app.loop suffice here?
Is there a use case where the App would run on a different loop than the Server?
|
LGTM |
| ssl=ssl_context)) | ||
|
|
||
| scheme = 'https' if ssl_context else 'http' | ||
| prompt = '127.0.0.1' if host == '0.0.0.0' else host |
There was a problem hiding this comment.
How should someone bind to public interface?
There was a problem hiding this comment.
sorry, read from end to top))
There was a problem hiding this comment.
Sorry, I don't follow.
Isn't knowledge of host/port info enough?
There was a problem hiding this comment.
As I already said -- I read diff from bottom to top) thought that you replaced '0.0.0.0' with localhost and bind to it)
asvetlov
added a commit
that referenced
this pull request
Jan 13, 2016
Implement web.run_app utility function
This was referenced Jan 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #690
Let's delay
python -m aiohttp.web HOST PORT pkg.module.main [ARGS]for a while.I've created #733 for that.
The PR adds
run_apputility function along with docs and tests.