Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8482/62173be backport][3.10] Fix incorrect rejection of ws:// and wss:// urls #8511

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 17, 2024

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) wk.cvs.github@sydorenko.org.ua
Co-authored-by: J. Nick Koston nick@koston.org
Co-authored-by: Sam Bull aa6bs0@sambull.org
(cherry picked from commit 62173be)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
(cherry picked from commit 62173be)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 17, 2024
@bdraco bdraco enabled auto-merge (squash) July 17, 2024 13:54
@bdraco bdraco disabled auto-merge July 17, 2024 13:57
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.42%. Comparing base (3bc89fe) to head (4b1f8da).
Report is 2 commits behind head on 3.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8511      +/-   ##
==========================================
- Coverage   97.49%   97.42%   -0.07%     
==========================================
  Files         108      108              
  Lines       33374    33416      +42     
  Branches     4004     4008       +4     
==========================================
+ Hits        32537    32557      +20     
- Misses        611      629      +18     
- Partials      226      230       +4     
Flag Coverage Δ
CI-GHA 97.34% <100.00%> (-0.06%) ⬇️
OS-Linux 97.02% <100.00%> (-0.06%) ⬇️
OS-Windows 94.72% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.73% <100.00%> (-0.01%) ⬇️
Py-3.10.11 96.84% <100.00%> (-0.01%) ⬇️
Py-3.10.14 96.81% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.04% <100.00%> (+<0.01%) ⬆️
Py-3.12.4 97.15% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.45% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.71% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.85% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.82% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 ?
VM-macos 96.73% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.02% <100.00%> (-0.06%) ⬇️
VM-windows 94.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) July 17, 2024 14:21
@bdraco bdraco merged commit c12a143 into 3.10 Jul 17, 2024
29 of 30 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/62173bea1e4e3538d46e6e9b94d727d870d86879/pr-8482 branch July 17, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants