Add additional clarification for creating objects that require a running event loop #8583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
added
backport-3.10
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8583 +/- ##
==========================================
- Coverage 97.70% 97.64% -0.07%
==========================================
Files 107 107
Lines 33443 33443
Branches 3927 3927
==========================================
- Hits 32677 32655 -22
- Misses 555 573 +18
- Partials 211 215 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8585 🤖 @patchback |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #8586 🤖 @patchback |
bdraco
added a commit
that referenced
this pull request
Aug 2, 2024
…reating objects that require a running event loop (#8585) Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco
added a commit
that referenced
this pull request
Aug 2, 2024
…reating objects that require a running event loop (#8586) Co-authored-by: J. Nick Koston <nick@koston.org>
cjwatson
added a commit
to cjwatson/blinkpy
that referenced
this pull request
Aug 5, 2024
aiohttp 3.10.0 removed the ability to create `aiohttp.ClientSession` instances without a running event loop (see aio-libs/aiohttp#8583), but a few of blinkpy's tests relied on that.
3 tasks
cjwatson
added a commit
to cjwatson/yalexs
that referenced
this pull request
Aug 5, 2024
aiohttp 3.10.0 removed the ability to create `aiohttp.ClientSession` instances without a running event loop (see aio-libs/aiohttp#8583), but one of yalexs's tests relied on that.
cjwatson
added a commit
to cjwatson/yalexs
that referenced
this pull request
Aug 5, 2024
aiohttp 3.10.0 removed the ability to create `aiohttp.ClientSession` instances without a running event loop (see aio-libs/aiohttp#8583), but one of yalexs's tests relied on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adjust changelog message to further clarify #6378.
References #8555