Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make n argument clearer #8948

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Make n argument clearer #8948

merged 1 commit into from
Aug 30, 2024

Conversation

Dreamsorcerer
Copy link
Member

Judging by the closed issues, we seem to have a lot of users who don't understand what "up to" means. This adds more words to hopefully make it clearer.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (76a00d1) to head (84e024e).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8948   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         107      107           
  Lines       34226    34226           
  Branches     4058     4058           
=======================================
  Hits        33637    33637           
  Misses        416      416           
  Partials      173      173           
Flag Coverage Δ
CI-GHA 98.17% <ø> (ø)
OS-Linux 97.83% <ø> (ø)
OS-Windows 96.24% <ø> (ø)
OS-macOS 97.51% <ø> (-0.01%) ⬇️
Py-3.10.11 97.60% <ø> (-0.01%) ⬇️
Py-3.10.14 97.53% <ø> (ø)
Py-3.11.9 97.77% <ø> (ø)
Py-3.12.5 97.88% <ø> (ø)
Py-3.9.13 97.49% <ø> (ø)
Py-3.9.19 97.43% <ø> (ø)
Py-pypy7.3.16 97.04% <ø> (ø)
VM-macos 97.51% <ø> (-0.01%) ⬇️
VM-ubuntu 97.83% <ø> (ø)
VM-windows 96.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit cc6d763 into master Aug 30, 2024
37 of 38 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-4 branch August 30, 2024 19:33
Copy link
Contributor

patchback bot commented Aug 30, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/cc6d76321151f6e5d2210815f8fa60cd8e7c76f1/pr-8948

Backported as #8949

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 30, 2024
(cherry picked from commit cc6d763)
Copy link
Contributor

patchback bot commented Aug 30, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/cc6d76321151f6e5d2210815f8fa60cd8e7c76f1/pr-8948

Backported as #8950

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 30, 2024
(cherry picked from commit cc6d763)
bdraco pushed a commit that referenced this pull request Aug 30, 2024
bdraco pushed a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant