Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump yarl to 1.9.6 #8952

Closed
wants to merge 2 commits into from
Closed

Bump yarl to 1.9.6 #8952

wants to merge 2 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 31, 2024 •
edited
Loading

changelog: aio-libs/yarl@v1.9.4...v1.9.6

Doing a manual bump instead of waiting for the bot to get a clean run with #8898

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Aug 31, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 31, 2024 •
edited
Loading

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
3274 4 3270 24
View the top 3 failed tests by shortest run time 
tests.test_urldispatch test_add_static_quoting
Stack Traces | 0.001s run time 
router = <aiohttp.web_urldispatcher.UrlDispatcher object at 0x1093b60b0>

    #x1B[0m#x1B[94mdef#x1B[39;49;00m #x1B[92mtest_add_static_quoting#x1B[39;49;00m(router: web.UrlDispatcher) -> #x1B[94mNone#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
        resource = router.add_static(#x1B[90m#x1B[39;49;00m
            #x1B[33m"#x1B[39;49;00m#x1B[33m/пре #x1B[39;49;00m#x1B[33m%2F#x1B[39;49;00m#x1B[33mфикс#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, pathlib.Path(aiohttp.#x1B[91m__file__#x1B[39;49;00m).parent, name=#x1B[33m"#x1B[39;49;00m#x1B[33mstatic#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
        )#x1B[90m#x1B[39;49;00m
        #x1B[94massert#x1B[39;49;00m router[#x1B[33m"#x1B[39;49;00m#x1B[33mstatic#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m] #x1B[95mis#x1B[39;49;00m resource#x1B[90m#x1B[39;49;00m
        url = resource.url_for(filename=#x1B[33m"#x1B[39;49;00m#x1B[33m/1 2/файл#x1B[39;49;00m#x1B[33m%2F#x1B[39;49;00m#x1B[33m.txt#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
>       #x1B[94massert#x1B[39;49;00m url.path == #x1B[33m"#x1B[39;49;00m#x1B[33m/пре /фикс/1 2/файл#x1B[39;49;00m#x1B[33m%2F#x1B[39;49;00m#x1B[33m.txt#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
#x1B[1m#x1B[31mE       AssertionError: assert '/пре %2Fфикс/1 2/файл%2F.txt' == '/пре /фикс/1 2/файл%2F.txt'#x1B[0m
#x1B[1m#x1B[31mE         #x1B[0m
#x1B[1m#x1B[31mE         - /пре /фикс/1 2/файл%2F.txt#x1B[0m
#x1B[1m#x1B[31mE         ?      ^#x1B[0m
#x1B[1m#x1B[31mE         + /пре %2Fфикс/1 2/файл%2F.txt#x1B[0m
#x1B[1m#x1B[31mE         ?      ^^^#x1B[0m

resource   = <StaticResource 'static' /%D0%BF%D1%80%D0%B5%20%2F%D1%84%D0%B8%D0%BA%D1%81 -> PosixPath('.../aiohttp/aiohttp/aiohttp')>
router     = <aiohttp.web_urldispatcher.UrlDispatcher object at 0x1093b60b0>
url        = URL('/%D0%BF%D1%80%D0%B5%20%2F%D1%84%D0%B8%D0%BA%D1%81/1%202/%D1%84%D0%B0%D0%B9%D0%BB%252F.txt')

#x1B[1m#x1B[31mtests/test_urldispatch.py#x1B[0m:489: AssertionError

tests.test_urldispatch test_route_dynamic_quoting
Stack Traces | 0.001s run time 
router = <aiohttp.web_urldispatcher.UrlDispatcher object at 0x10943e800>

    #x1B[0m#x1B[94mdef#x1B[39;49;00m #x1B[92mtest_route_dynamic_quoting#x1B[39;49;00m(router: web.UrlDispatcher) -> #x1B[94mNone#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
        handler = make_handler()#x1B[90m#x1B[39;49;00m
        route = router.add_route(#x1B[33m"#x1B[39;49;00m#x1B[33mGET#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33mr#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33m/пре #x1B[39;49;00m#x1B[33m%2F#x1B[39;49;00m#x1B[33mфикс/#x1B[39;49;00m#x1B[33m{arg}#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, handler)#x1B[90m#x1B[39;49;00m
    #x1B[90m#x1B[39;49;00m
        url = route.url_for(arg=#x1B[33m"#x1B[39;49;00m#x1B[33m1 2/текст#x1B[39;49;00m#x1B[33m%2F#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
>       #x1B[94massert#x1B[39;49;00m url.path == #x1B[33m"#x1B[39;49;00m#x1B[33m/пре /фикс/1 2/текст#x1B[39;49;00m#x1B[33m%2F#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
#x1B[1m#x1B[31mE       AssertionError: assert '/пре %2Fфикс/1 2/текст%2F' == '/пре /фикс/1 2/текст%2F'#x1B[0m
#x1B[1m#x1B[31mE         #x1B[0m
#x1B[1m#x1B[31mE         - /пре /фикс/1 2/текст%2F#x1B[0m
#x1B[1m#x1B[31mE         ?      ^#x1B[0m
#x1B[1m#x1B[31mE         + /пре %2Fфикс/1 2/текст%2F#x1B[0m
#x1B[1m#x1B[31mE         ?      ^^^#x1B[0m

handler    = <function make_handler.<locals>.handler at 0x109273880>
route      = <ResourceRoute [GET] <DynamicResource  /%D0%BF%D1%80%D0%B5%20%2F%D1%84%D0%B8%D0%BA%D1%81/{arg}> -> <function make_handler.<locals>.handler at 0x109273880>
router     = <aiohttp.web_urldispatcher.UrlDispatcher object at 0x10943e800>
url        = URL('/%D0%BF%D1%80%D0%B5%20%2F%D1%84%D0%B8%D0%BA%D1%81/1%202/%D1%82%D0%B5%D0%BA%D1%81%D1%82%252F')

#x1B[1m#x1B[31mtests/test_urldispatch.py#x1B[0m:662: AssertionError

tests.test_urldispatch test_dynamic_match_unquoted_path
Stack Traces | 0.003s run time 
router = <aiohttp.web_urldispatcher.UrlDispatcher object at 0x1093b4d30>

    #x1B[0m#x1B[94masync#x1B[39;49;00m #x1B[94mdef#x1B[39;49;00m #x1B[92mtest_dynamic_match_unquoted_path#x1B[39;49;00m(router: web.UrlDispatcher) -> #x1B[94mNone#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
        handler = make_handler()#x1B[90m#x1B[39;49;00m
        router.add_route(#x1B[33m"#x1B[39;49;00m#x1B[33mGET#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33m"#x1B[39;49;00m#x1B[33m/#x1B[39;49;00m#x1B[33m{path}#x1B[39;49;00m#x1B[33m/#x1B[39;49;00m#x1B[33m{subpath}#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, handler)#x1B[90m#x1B[39;49;00m
        resource_id = #x1B[33m"#x1B[39;49;00m#x1B[33mmy#x1B[39;49;00m#x1B[33m%2F#x1B[39;49;00m#x1B[33mpath#x1B[39;49;00m#x1B[33m%#x1B[39;49;00m#x1B[33m7Cwith#x1B[39;49;00m#x1B[33m%21s#x1B[39;49;00m#x1B[33mome#x1B[39;49;00m#x1B[33m%25s#x1B[39;49;00m#x1B[33mtrange#x1B[39;49;00m#x1B[33m%24c#x1B[39;49;00m#x1B[33mharacters#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
        req = make_mocked_request(#x1B[33m"#x1B[39;49;00m#x1B[33mGET#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33mf#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33m/path/#x1B[39;49;00m#x1B[33m{#x1B[39;49;00mresource_id#x1B[33m}#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
        match_info = #x1B[94mawait#x1B[39;49;00m router.resolve(req)#x1B[90m#x1B[39;49;00m
>       #x1B[94massert#x1B[39;49;00m match_info == {#x1B[33m"#x1B[39;49;00m#x1B[33mpath#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m: #x1B[33m"#x1B[39;49;00m#x1B[33mpath#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33m"#x1B[39;49;00m#x1B[33msubpath#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m: unquote(resource_id)}#x1B[90m#x1B[39;49;00m
#x1B[1m#x1B[31mE       AssertionError: assert <MatchInfo {'... 0x109273d90>> == {'path': 'pat...e$characters'}#x1B[0m
#x1B[1m#x1B[31mE         #x1B[0m
#x1B[1m#x1B[31mE         Omitting 1 identical items, use -vv to show#x1B[0m
#x1B[1m#x1B[31mE         Differing items:#x1B[0m
#x1B[1m#x1B[31mE         #x1B[0m{#x1B[33m'#x1B[39;49;00m#x1B[33msubpath#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m: #x1B[33m'#x1B[39;49;00m#x1B[33mmy#x1B[39;49;00m#x1B[33m%2F#x1B[39;49;00m#x1B[33mpath|with!some#x1B[39;49;00m#x1B[33m%s#x1B[39;49;00m#x1B[33mtrange$characters#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m}#x1B[90m#x1B[39;49;00m != #x1B[0m{#x1B[33m'#x1B[39;49;00m#x1B[33msubpath#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m: #x1B[33m'#x1B[39;49;00m#x1B[33mmy/path|with!some#x1B[39;49;00m#x1B[33m%s#x1B[39;49;00m#x1B[33mtrange$characters#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m}#x1B[90m#x1B[39;49;00m#x1B[0m
#x1B[1m#x1B[31mE         #x1B[0m
#x1B[1m#x1B[31mE         Full diff:#x1B[0m
#x1B[1m#x1B[31mE         #x1B[0m#x1B[92m+ <MatchInfo {'path': 'path', 'subpath': 'my%2Fpath|with!some%strange$characters'}: <ResourceRoute [GET] <DynamicResource  /{path}/{subpath}> -> <function make_handler.<locals>.handler at 0x109273d90>>#x1B[39;49;00m#x1B[90m#x1B[39;49;00m#x1B[0m
#x1B[1m#x1B[31mE         #x1B[91m- {#x1B[39;49;00m#x1B[90m#x1B[39;49;00m#x1B[0m
#x1B[1m#x1B[31mE         #x1B[91m-     'path': 'path',#x1B[39;49;00m#x1B[90m#x1B[39;49;00m#x1B[0m
#x1B[1m#x1B[31mE         #x1B[91m-     'subpath': 'my/path|with!some%strange$characters',#x1B[39;49;00m#x1B[90m#x1B[39;49;00m#x1B[0m
#x1B[1m#x1B[31mE         #x1B[91m- }#x1B[39;49;00m#x1B[90m#x1B[39;49;00m#x1B[0m

handler    = <function make_handler.<locals>.handler at 0x109273d90>
match_info = <MatchInfo {'path': 'path', 'subpath': 'my%2Fpath|with!some%strange$characters'}: <ResourceRoute [GET] <DynamicResource  /{path}/{subpath}> -> <function make_handler.<locals>.handler at 0x109273d90>>
req        = <Request GET /path/my%2Fpath|with!some%strange$characters >
resource_id = 'my%2Fpath%7Cwith%21some%25strange%24characters'
router     = <aiohttp.web_urldispatcher.UrlDispatcher object at 0x1093b4d30>

#x1B[1m#x1B[31mtests/test_urldispatch.py#x1B[0m:772: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@bdraco
Copy link
Member Author

bdraco commented Aug 31, 2024

This likely needs to be done in #8898 to adjust the tests so merged this in there so I can test that PR

@bdraco bdraco changed the title Bump yarl to 1.9.5 Bump yarl to 1.9.6 Aug 31, 2024
@Dreamsorcerer Dreamsorcerer deleted the bump_yarl branch August 31, 2024 19:36
@dopplershift dopplershift mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz will be requested when the pull request is marked ready for review webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov will be requested when the pull request is marked ready for review asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @Dreamsorcerer