Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mocked request helper #900

Merged
merged 5 commits into from
Jul 7, 2016
Merged

Make mocked request helper #900

merged 5 commits into from
Jul 7, 2016

Conversation

jettify
Copy link
Member

@jettify jettify commented Jun 2, 2016 •
edited
Loading

Adds make_mocked_request to test_utils

Fix for (#771)

Checklist

  • Code is written and well
  • Tests for the changes are provided
  • Documentation reflects the changes

@coveralls
Copy link

coveralls commented Jun 2, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.005%) to 98.209% when pulling c41c34a on jettify:make-mocked-request into c059e0b on KeepSafe:master.

@asvetlov asvetlov mentioned this pull request Jun 5, 2016
Closed
@coveralls
Copy link

coveralls commented Jun 7, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.004%) to 98.102% when pulling 86a9d11 on jettify:make-mocked-request into f180199 on KeepSafe:master.

@asvetlov
Copy link
Member

asvetlov commented Jun 9, 2016

Would you add couple words to the doc?
I believe docs/testing.py is a good place for it.

@pfreixes
Copy link
Contributor

pfreixes commented Jul 3, 2016

Very keen on that feature, any advances in this PR?

@jettify
Copy link
Member Author

jettify commented Jul 4, 2016

Sorry for delay, will try to update docs soon, hopfully today.

On Sun, Jul 3, 2016, 21:59 Pau Freixes notifications@github.com wrote:

Very keen on that feature, any advances in this PR?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#900 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AANoZ9sVGR5fwChr3WK83XM04K3wX3e5ks5qSAalgaJpZM4ItA8o
.

@coveralls
Copy link

coveralls commented Jul 4, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.004%) to 98.102% when pulling 020f198 on jettify:make-mocked-request into f2c12f7 on KeepSafe:master.

@asvetlov asvetlov merged commit d26d9dc into aio-libs:master Jul 7, 2016
@asvetlov asvetlov mentioned this pull request Jul 7, 2016
Closed
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jettify @coveralls @asvetlov @pfreixes @nickolai-dr