-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make raw_host and port cached_property #1044
Conversation
aiohttp accesses these properties quite often because of the calls to is_absolute and urllib has to reparse _hostinfo each time
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1044 +/- ##
=======================================
Coverage 62.36% 62.36%
=======================================
Files 38 38
Lines 6616 6616
Branches 356 356
=======================================
Hits 4126 4126
Misses 2463 2463
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
I tried to fix the chronographer in #1053 but it looks like its coming in from the org level and not in the github config so its not something I have access to solve. |
It looks like changelog checks haven't been working for a while per #954 (comment) |
Added skip label as a workaround since changelog bot is currently not working |
What do these changes do?
aiohttp accesses these properties quite often because of the calls to
is_absolute
/update_headers
andurllib
has to reparse_hostinfo
each time.Are there changes in behavior for the user?
No