Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for handling port 0 #1182

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add test coverage for handling port 0 #1182

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de509d0
Add test coverage for handling port 0
bdraco Oct 8, 2024
8341a59
Add test coverage for handling port 0
bdraco Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/test_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,6 +1486,15 @@ def test_is_default_port_for_unknown_scheme():
assert not url.is_default_port()


def test_handling_port_zero():
url = URL("http://example.com:0")
assert url.explicit_port == 0
assert url.explicit_port == url._val.port
assert url._port_not_default == 0
assert str(url) == "http://example.com:0"
assert not url.is_default_port()


#


Expand Down
Loading