[CollectionView] Guard against a UIKit crash caused by attempting to scroll to an item that no longer exists #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scroll to an item that no longer exists Calling `scrollToItem(…)` with in invalid index path raises an exception: > NSInternalInconsistencyException: Attempted to scroll the collection view to an out-of-bounds item We must guard against this to check to ensure that this never happens, as we call this method repeatedly and the items/section may change out from under us.
erichoracek
force-pushed
the
eh--fix-crash
branch
from
9199617
to
93941a3
Compare
kierajmumick
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Calling
scrollToItem(…)with in invalid index path raises an exception:We must guard against this to check to ensure that this never happens, as we call this method repeatedly and the items/section may change out from under us.
How was it tested?
How did you verify that this change accomplished what you expected? Add more detail as needed.
Pull request checklist
All items in this checklist must be completed before a pull request will be reviewed.
CollectionViewConfigurationCHANGELOG.mdentry in the "Unreleased" section for any library changes