Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update source tiktok to support python 3.11 #39578

Closed
wants to merge 1 commit into from

Conversation

DLT1412
Copy link

@DLT1412 DLT1412 commented Jun 19, 2024

support python3.11
python/cpython#100458
python/cpython#84247
python3.11 change behavior of str() Enum class, use StrEnum to not break logic

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 3:52am

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2024

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jun 19, 2024
@DLT1412 DLT1412 changed the title Update streams.py update source tiktok to support python 3.11 Jun 20, 2024
@marcosmarxm
Copy link
Member

@DLT1412 can you link an Airbyte issue or why you're doing this change?

@DLT1412
Copy link
Author

DLT1412 commented Jun 21, 2024

@marcosmarxm as ref link, python3.11 change behavior of mix class str and Enum
then f-string value f"AUCTION_{ReportLevel.AD} become AUCTION_ReportLevel.AD make invalid param of payload
f"AUCTION_{ReportLevel.AD} = AUCTION_AD with python <=3.10
so I think we need to support with use StrEnum (at python/cpython#100458) to deal with that.

@lazebnyi
Copy link
Collaborator

will be fixed in #38316

@DLT1412 DLT1412 closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants