Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global markdown mode remake based on Scopes #4923

Draft
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Sep 9, 2022

Issue #, if available: #3942, #3750, #2595, #2950, #5056, #4358, #1390

Would fix after implementing embedded scope-based/normal modes: #2978

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mkslanc mkslanc marked this pull request as draft September 10, 2022 09:45
@mkslanc mkslanc changed the title Scopes markdown Global markdown mode remake based on Scopes Feb 14, 2023
…kdown

# Conflicts:
#	src/edit_session/folding.js
#	src/layer/text.js
#	src/mode/_test/highlight_rules_test.js
#	src/mode/behaviour/behaviour_test.js
#	src/mode/text.js
#	src/scope.js
#	src/tokenizer.js
#	src/tooltip.js
var parent = scope.get("codeBlock" + language);
parent.language = language;
parent.indent = m[1].length;
parent.endMarker = m[2];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code is broken because it is changing properties on the same scope object, it should be something like parent.get(this.next, {language, indent, marker, toString() { [language, indent, marker].join("|") }})`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants