Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add penalty on case mismatch to completion filter #5626

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

FIameCaster
Copy link
Contributor

Issue #, if available: N/A

I read through the code of the filterCompletions method and saw a TODO comment asking to implement a penalty on case mismatch. Not entirely sure what would be a good value for the penalty, but I went with 3 for each character and it works well enough.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.92%. Comparing base (0192880) to head (3053e0d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5626   +/-   ##
=======================================
  Coverage   86.91%   86.92%           
=======================================
  Files         594      594           
  Lines       43222    43246   +24     
  Branches     7155     7156    +1     
=======================================
+ Hits        37568    37593   +25     
+ Misses       5654     5653    -1     
Flag Coverage Δ
unittests 86.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant