Add support for simba #25
Conversation
| @@ -21,19 +21,21 @@ name = "twofloat" | |||
| test = true | |||
|
|
|||
| [features] | |||
| default = ["std", "math_funcs"] | |||
| default = ["std", "math_funcs", "simba"] | |||
There was a problem hiding this comment.
I think it would be better to leave this as an optional additional feature
| } | ||
|
|
||
| fn pi() -> Self { | ||
| f64::pi().into() |
There was a problem hiding this comment.
This and the similar methods should use the constants defined in TwoFloat::consts
| return false; | ||
| } | ||
|
|
||
| self.hi().ulps_eq(&other.hi(), epsilon.into(), max_ulps) |
There was a problem hiding this comment.
This doesn't look correct - if self.hi is normal, then ulps would be determined by self.lo. If self.hi is subnormal or zero, then self.lo would be zero and the ulps would be determined by the value of self.hi.
| } | ||
|
|
||
| fn extract(&self, _: usize) -> Self::Element { | ||
| *self |
There was a problem hiding this comment.
According to the contract, this should panic if i >= self.lanes()
| } | ||
|
|
||
| fn replace(&mut self, _: usize, val: Self::Element) { | ||
| *self = val |
There was a problem hiding this comment.
According to the contact, this should panic if i >= self.lanes()
| } | ||
|
|
||
| fn cbrt(self) -> Self { | ||
| todo!() |
There was a problem hiding this comment.
This should call the cbrt function on the TwoFloat struct.
|
Thanks for all the comments! Would it be possible for you to edit the code and merge it in? I'm honestly quite unfamiliar with the whole low-level ecosystem surrounding num_traits, simba, and such. |
|
Apologies for the delay on this, will take another look after I do the 0.7 release. |
No description provided.