Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes deprecation warnings for Scala 2.13 #874

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Fixes deprecation warnings for Scala 2.13 #874

merged 3 commits into from
Mar 22, 2021

Conversation

nvollmar
Copy link
Contributor

References #864

@nvollmar
Copy link
Contributor Author

@patriknw may I ping you for a review?

@johanandren
Copy link
Member

OK TO TEST

@nvollmar
Copy link
Contributor Author

Tests were already run, just a review missing 👍

@johanandren
Copy link
Member

Hehe, yeah, I missed that this isn't a PR in akka/akka when going through my notifications this morning :)

johanandren
johanandren approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one string replacement remark

core/src/test/scala/akka/persistence/cassandra/CassandraSpec.scala Show resolved Hide resolved
@octonato octonato merged commit 53222ef into akka:master Mar 22, 2021
@nvollmar nvollmar deleted the wip-864-scala213-deprecations-nvo branch March 22, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

@octonato octonato octonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvollmar @johanandren @octonato