Skip to content

Commit

Permalink
fix: electron builder (#647)
Browse files Browse the repository at this point in the history
  • Loading branch information
akosbalasko authored Aug 20, 2024
1 parent 12e1603 commit 596e7af
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 12 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/electronbuilder-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ jobs:
- name: Install Node.js, NPM and Yarn
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
- run: npm i -g npm@10

- name: Electron Builder Action(Using Node 20)
uses: vingeraycn/action-electron-builder@v1.0.1
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/release-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ jobs:
- name: Install Node.js, NPM and Yarn
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18

- name: Electron Builder Action (node16)
uses: gugiserman/action-electron-builder@v1.6.1-node16

- run: npm i -g npm@10

- name: Electron Builder Action(Using Node 20)
uses: vingeraycn/action-electron-builder@v1.0.1
with:
# GitHub token, automatically provided to the action
# (No need to define this secret in the repo settings)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-tests-windows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
node-version: [16.x, 18.x]
node-version: [18.x, 20.x]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
node-version: [ 16.x]
node-version: [ 18.x, 20.x]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/semantic-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Install Node.js, NPM and Yarn
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18

- name: build code
run: npm i && npm run compile
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@
"zip-a-folder": "2.0.0"
},
"engines": {
"node": ">=10.18.1",
"npm": ">=5.6.0"
"node": ">=18.17.0",
"npm": ">=10.10.0"
},
"repository": {
"type": "git",
Expand Down

0 comments on commit 596e7af

Please sign in to comment.