Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamps of MD files are being set to conversion time #623

Closed
lawabider opened this issue Apr 4, 2024 · 11 comments · Fixed by #624
Closed

Timestamps of MD files are being set to conversion time #623

lawabider opened this issue Apr 4, 2024 · 11 comments · Fixed by #624

Comments

@lawabider
Copy link

I'm exporting from Evernote 6.25.1.9091 , in Windows.

Copy link

github-actions bot commented Apr 4, 2024

Yihaa, thank you for reporting me this issue and to let me improve Yarle!

@lawabider lawabider changed the title Timestamps of MD files are being set to conversion time, not note creation time. Timestamps of MD files are being set to conversion time Apr 4, 2024
@akosbalasko
Copy link
Owner

Hi @lawabider ,
There are two options here: I'm not sure that the exported enex file contains the creation timestamp if the export was done using this old version of Evernote.
The other point would be Windows, because Yarle uses a 3rd party lib to handle creation times dedicatedly for Windows (I mean to be transparent by platform). Which Windows version do you use?

ipcjs added a commit to ipcjs/yarle that referenced this issue Apr 5, 2024
ipcjs added a commit to ipcjs/yarle that referenced this issue Apr 5, 2024
@lawabider
Copy link
Author

lawabider commented Apr 7, 2024

My Windows version is 10.0.22000.
I think I was wrong about the creation timestamp; it was reset when I copied the files. I should have moved them instead.
I still don't think that the file modified timestamp matches the note's last updated timestamp. I have been assuming that it's supposed to.

@ipcjs
Copy link

ipcjs commented Apr 7, 2024

The PR has fixed the issue: #624

@lawabider
Copy link
Author

Can someone help me to use npx with github urls?
This works
npx -p yarle-evernote-to-md@latest yarle --configFile config.json

But this attempt failed:
npx -p github:akosbalasko/yarle@latest yarle --configFile config.json

@akosbalasko
Copy link
Owner

hi @lawabider
Why do you want to executed yarle dedicatedly from github? the latest version in npm is what you see here on github, so it should be the same.

@akosbalasko
Copy link
Owner

@ipcjs please check your PR, it fails on Ubuntu and Mac, looks working on Windows only.

@lawabider
Copy link
Author

@akosbalasko I was hoping to try ipcjs's fork.
I'm in a bit of a rabbit hole here, being weak at github and knowing nothing of the javascript world.

@akosbalasko
Copy link
Owner

@lawabider that's a bit more complicated, I mean using an other fork, you'd need to build his fork etc... so I would suggest to wait a bit until his PR is approved and merged, currently we are facing with some platform issues (works on Windows, but do not work on any other OS). I try to resolve it today or at most tomorrow.

@ipcjs
Copy link

ipcjs commented Apr 8, 2024

@lawabider I have fixed the test cases

akosbalasko added a commit that referenced this issue Apr 11, 2024
* fix: timestamp error

Close #623

* fix: test error on linux

* wip: perf code style

---------

Co-authored-by: Akos Balasko <akos0215@gmail.com>
@akosbalasko
Copy link
Owner

@ipcjs thanks for the contribution, merged and released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants