fix: don't escape markdown characters in code #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosbalasko
approved these changes
Jul 17, 2021
Fixes extraneous backslashes introduced into code blocks. Turndown tries to avoid escaping Markdown characters in code, but doesn't recognize Evernote code blocks. This converts `some_var` to `some\_var`, `# comment` to `\# comment`, `*ptr` to `\*ptr`, etc. (likely breaking the code). Since turndown applies its escape function before the content arrives in yarle's code block rules, fix is to unescape it there. (Note that turndown always escapes `\` to `\\`, so unescaping all backslash sequences will always result in the original code, even if it contained backslashes.)
medmunds
force-pushed
the
fix/code-escaping
branch
from
cf02e24
to
9f91cf3
Compare
akosbalasko
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes extraneous backslashes introduced into code blocks.
Turndown tries to avoid escaping Markdown characters in code,
but doesn't recognize Evernote code blocks. This converts
some_vartosome\_var,# commentto\# comment,*ptrto\*ptr, etc. (likely breaking the code).Since turndown applies its escape function before the content
arrives in yarle's code block rules, fix is to unescape it there.
(Note that turndown always escapes
\to\\, so unescapingall backslash sequences will always result in the original code,
even if it contained backslashes.)