Added deconstruction function and other fixes #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added deconstruct function. Now you can deconstruct buildings level by level Fixed spyreports' ugliness. More elegant, compact and smart Fixed stuff like missing spaces and quotation marks Fixed friendly_fleet and hostile_fleet crash on id casting
Added deconstruct test
Added deconstruct explanation
PiecePaperCode
requested changes
Aug 24, 2021
Added cancel_building function to cancel construction/deconstruction of buildings and cancel_research to cancel the ongoing research. (Didn't test with commander) Fixed celestial function temperature extraction. Instead of trying a list of possible regex we can extract the two numbers in the textContent[3] var using another regex.
Should I also add the research test?
PiecePaperCode
approved these changes
Aug 27, 2021
| 'type': type} | ||
| ) | ||
|
|
||
| def cancel_building(self, id): |
There was a problem hiding this comment.
they are only used by cancel you could nest them instead of making them visible by the user. but its fine also as is
| ).metal_mine | ||
| self.assertTrue(before.level > after.level or after.in_construction) | ||
|
|
||
| def check_cancel(self): |
There was a problem hiding this comment.
the test framework dosent run in a row usualy. if one start before the other the cancel test will fail. ether you combine the two or you implement them to eachother. not really a problem as it can be changed easy
There was a problem hiding this comment.
Maybe the best option is to test both simultaneously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added deconstruct function. Now you can deconstruct buildings level by level.
I found that useful on my mines upgrade schedule. Once the planet produce a good amount of deuterium then it can convert the energy production from solar to fusion and therefore consume less spaces
Fixed spyreports' ugliness. More elegant, compact and smart
Fixed stuff like missing spaces and quotation marks
#117
Fixed friendly_fleet and hostile_fleet crash on id casting
Can this fix the problem and also do not destroy all running bots?