Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement getVisibleRegion() with MKMapView.region #24

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Implement getVisibleRegion() with MKMapView.region #24

wants to merge 1 commit into from

Conversation

javb99
Copy link

@javb99 javb99 commented May 14, 2021

This implementation respects the padding value and insets the region based on that padding. This allows setting the bounds and reading the bounds to have the same semantics with respect to the padding.

Pre-launch Checklist

  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making if a test is possible.
  • All existing and new tests are passing.

@javb99
Implement getVisibleRegion() with MKMapView.region
4fc1de3 
This implementation respects the `padding` value and insets the region based on that padding. This allows setting the bounds and reading the bounds to have the same semantics with respect to the `padding`.
@LuisThein LuisThein force-pushed the master branch 4 times, most recently from 75cfa05 to 6b392d9 Compare July 30, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@javb99