Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply flutter_lints and update Android example #64

Merged
merged 3 commits into from
May 6, 2024

Conversation

renefloor
Copy link
Collaborator

This PR adds an analysis_options file with flutter_lints and applies all the changes suggested by the analyzer.
I deliberately haven't updated pubspec or changelog, because nothing really changed.

List which issues are fixed by this PR.

Pre-launch Checklist

  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making if a test is possible.
  • All existing and new tests are passing.

jogboms
jogboms previously approved these changes Feb 23, 2024
mvolpato
mvolpato previously approved these changes Feb 23, 2024
@millerf
Copy link

millerf commented Mar 9, 2024

This one can be closed as I merged it in #66

@jogboms
Copy link
Collaborator

jogboms commented Mar 14, 2024

This repo is actively maintained just a few hurdles to cross. Also, your PR is not merged yet @millerf how do you mean?

@millerf
Copy link

millerf commented Mar 14, 2024

This repo is actively maintained just a few hurdles to cross. Also, your PR is not merged yet @millerf how do you mean?

I merged those changes in #66 @jogboms

Copy link

@millerf millerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review...

@renefloor
Copy link
Collaborator Author

@millerf At Albert Heijn we wanted to use this package, but also found some issues and possible improvement that we wanted first. After I got in contact with @LuisThein we decided to move the whole package to the Albert Heijn Technology organisation and we just started making improvements. This PR is the first step in that, but we have to manage some corporate administration first. The second step (which was the requirement of AH) is that we are going to migrate to a federated plugin setup. The big benefit of that is that you only add dependencies that you actually use. In the current setup the iOS app will also depend on the native Google Maps libraries, while you don't want that.

Once we are migrated to the federated setup we'll take a look at other issues and feature requests. So there is definitely no reason to publish a different fork to pub.dev as we'll also take over the pub.dev ownership from Luis.

@millerf
Copy link

millerf commented Mar 15, 2024

@renefloor Please let us know when the new plugin is published..

@renefloor renefloor dismissed stale reviews from mvolpato and jogboms via 4b36292 April 17, 2024 08:14
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
@renefloor renefloor changed the title Add flutter_lints and apply all suggestions chore: apply flutter_lints and update Android example May 3, 2024
@renefloor renefloor closed this May 3, 2024
@renefloor renefloor reopened this May 3, 2024
@renefloor renefloor merged commit d2db88c into master May 6, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants