Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Federated plugin structure #67

Merged
merged 16 commits into from
Jun 3, 2024
Merged

Conversation

renefloor
Copy link
Collaborator

@renefloor renefloor commented May 6, 2024

This PR migrates the plugin to a federated plugin setup.
This allows devs to use a different type of platform map, for example if they don't like Google maps on Android but want to use something else, but more importantly, this removes the dependency on GoogleMaps from the iOS app.

Still to do

  • Update Readme's and package descriptions
  • Check if we can verify version numbers in the github workflow
  • Update changelogs
  • Update licenses

Issue #65

Pre-launch Checklist

  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making if a test is possible.
  • All existing and new tests are passing.

@renefloor renefloor changed the title Feature/plugin federation Migrate to Federated plugin structure May 6, 2024
@renefloor renefloor force-pushed the feature/plugin-federation branch 3 times, most recently from 3dfe0e0 to 8923aa1 Compare May 6, 2024 11:43
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
@renefloor renefloor marked this pull request as ready for review May 6, 2024 13:22
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Copy link
Collaborator

@mvolpato mvolpato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I run the example on iOS and it works well.

mvolpato
mvolpato previously approved these changes May 8, 2024
@renefloor renefloor dismissed stale reviews from jogboms and mvolpato via 37f3475 May 17, 2024 07:26
renefloor and others added 3 commits May 17, 2024 09:42
Co-authored-by: Jan van den Berg <koozz@linux.com>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Co-authored-by: Michele Volpato <mvolpato@users.noreply.github.com>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
@renefloor renefloor merged commit b722116 into master Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants