You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation of the Amber TI parser (amber.extract_dHdl) returns a dataframe with native Amber units (as used to be the case in alchemical-analysis) instead of the prescribed reduced dHdl standard form: the potential energy derivatives should be divided by 1/kT.
@shuail sorry, this slipped through when I was reviewing earlier. We need to make sure that all parsers produce the same dataframes, though, so this is a necessity.
@dotsdl I know you're busy (GitHub displays status nowadays?!?) but because we talked about it, I am tentatively assigning you to this issue and #56 . Maybe @shuail can give input when needed.
- fix#57 (TI parser)
- fix#56 (FEP parser)
- adjusted tests by explicitly converting the originally supplied
energies in kcal/mol to kT
- TODO: No FEP tests for the Amber data that actually process the files
The current implementation of the Amber TI parser (amber.extract_dHdl) returns a dataframe with native Amber units (as used to be the case in alchemical-analysis) instead of the prescribed reduced dHdl standard form: the potential energy derivatives should be divided by 1/kT.
See for example
alchemlyb/src/alchemlyb/parsing/gmx.py
Line 132 in e5b2e58
Todo:
amber.extract_dHdl()
needs additional temperatureT
argumentdHdl = beta * dHdL
withbeta = 1/(kB*T)
(See also #56 )
The text was updated successfully, but these errors were encountered: