add Session::channel_direct_streamlocal #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demosdemon
force-pushed
the
pr/channel_direct_streamlocal
branch
from
b18f3fc
to
9b66bce
Compare
demosdemon
force-pushed
the
pr/channel_direct_streamlocal
branch
from
9b66bce
to
dc441f9
Compare
|
This is great! Is there anything blocking this from being merged? I guess the lack of maintainers in this crate? |
|
Thank you for the new feature and the very detailed PR! |
|
Actually messing with it in my fork, I found the test breaks the windows build. I can make a small PR for that. |
I also noticed that after I had merged this and had to step away yesterday. If you want to make a quick PR I would appreciate it. |
|
Done, PR #302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for this extension was officially added to libssh2 in v1.11.0 via libssh2/libssh2#945.
This PR updates libssh2 to this new version and adds the bindings for
libssh2_channel_direct_streamlocal_ex.Closes #279
See libssh2/libssh2@4f0f4bf for reference to explain the
build.rschanges.Test Plan:
https://gist.github.com/demosdemon/475db259ebf63cfb35cb1fb4186a67cd