Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output of GX/GN in non-solo runs #1190

Open
deto opened this issue Mar 30, 2021 · 7 comments
Open

Output of GX/GN in non-solo runs #1190

deto opened this issue Mar 30, 2021 · 7 comments
Milestone

Comments

@deto
Copy link

deto commented Mar 30, 2021

The release notes for 2.7.6 note that GX/GN can be output for all runs, however I just tried a run of the form:

/home/ubuntu/programs/STAR-2.7.8a/bin/Linux_x86_64/STAR \
    --outSAMtype BAM SortedByCoordinate \
    --outSAMunmapped Within \
    --outSAMattributes NH HI AS nM GX GN \
    --genomeDir /home/ubuntu/References/GRCh38_STAR \
    --readFilesIn path/to/my/reads \
    --quantMode GeneCounts \
    --runThreadN 16

And the resulting BAM file does not contain these. Is there an argument that I'm missing?

(The fixed was referenced in #945)

@alexdobin alexdobin added the issue: code Likely to be an issue with STAR code label Mar 31, 2021
@alexdobin
Copy link
Owner

Hi David,

I was struggling with this issue for a few releases - could you please try 2.7.8a?

Cheers
Alex

@deto
Copy link
Author

deto commented Mar 31, 2021

This was in 2.7.8a, actually

@alexdobin alexdobin added bug and removed issue: code Likely to be an issue with STAR code labels Apr 1, 2021
@alexdobin alexdobin added this to the 2.7.8b: bug-fix release milestone Apr 1, 2021
@alexdobin
Copy link
Owner

Hi David,

you are right, this is still not working. Will fix it shortly.
Note that GX/GN tags are assigned to STARsolo-like rules, i.e. the reads are required to be concordant with transcript models. On the other hand, the counts for --quantMode GeneCounts only require 1b overlap with exons.

Cheers
Alex

@cnk113
Copy link

cnk113 commented May 4, 2021

I just want to add this doesn't seem to work with CB_samTagOut parameter set, although looking at the source code it looks like it was intended. Would it be possible to add the parameter to add the GX/GN tag w/o quantification? As well as allowing it with the GeneFull parameter?

@alexdobin
Copy link
Owner

alexdobin commented May 5, 2021

Hi Chang,

GX/GN should now work for GeneFull in release 2.7.9, and even non-solo runs. I will check what's going on with CB_samTagOut.

Cheers
Alex

@cnk113
Copy link

cnk113 commented May 6, 2021

I think the issue is in ParametersSolo.cpp line 218. I ended up removing the outer if statement and works for me.

if (type != SoloTypes::CB_samTagOut) {//gene quantification is needed

@alexdobin
Copy link
Owner

Hi Chang,

you are right, removing this condition should make it work. I think there should be no issues, but I need to test it.

Cheers
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants