replace if/else with a selector #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In systemd, the service is currently not being restarted after configuration changes. See voxpupuliGH-382 The acceptance test in this commit reconfigures prometheus with the admin API enabled and then attempts to access it. See https://prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis
The [unreliable](https://puppet.com/docs/puppet/5.5/lang_defaults.html#behavior) resource default ``` File{ notify => Class['prometheus::run_service'] } ``` is replaced by a `$notify` variable that is set on the relevant file resources *and* `systemd::unit_file`. Some care was needed to make sure the reload behaviour wasn't broken. ie If the configuration change is just a new scrape job that is collected, the service should only be reloaded, not restarted. Fixes voxpupuli#382
bastelfreak
changed the title
alexjfisher
force-pushed
the
issue_382
branch
from
ddc9d7b
to
8588d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues