Bundler support: run eye commands within a project path #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using with capistrano-bundler, the working directory should contain Gemfile.
|
I use eye to manage multiple projects deployed in different locations. So, eye itself not bundled with project. If there are any way to support both cases bundled and not bundled eye I will merge this patch. |
|
This PR only adds the requirement to run the eye command inside the project path. It doesn't add bundler's calls anywhere in the code, because this work is done by the capistrano-bundler gem. So it will work perfectly even with unbundled eye. |
alexsergeyev
added a commit
that referenced
this pull request
Jun 8, 2015
Bundler support: run eye commands within a project path
|
Yes. Everything looks fine. Thanks for PR |
|
Alex, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alex,
Thank you for the work on this gem!
I've added support for capistrano-bundler in this PR and would like to merge it to the upstream.
When using with capistrano-bundler, the working directory should contain Gemfile. Otherwise, it would fail looking for Gemfile.
I would like to answer any questions regarding this PR. Looking forward to your review.