Skip to content

Commit

Permalink
Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.
Browse files Browse the repository at this point in the history
  • Loading branch information
cjcenizal committed Aug 4, 2019
1 parent c2aafcf commit 8697967
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions src/plugins/es_ui_shared/public/request/request.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ describe('request lib', () => {
});
});

describe('pollIntervalMs', () => {
// FLAKY: https://github.com/elastic/kibana/issues/42561
describe.skip('pollIntervalMs', () => {
it('sends another request after the specified time has elapsed', async () => {
initUseRequest({ ...successRequest, pollIntervalMs: 30 });
await wait(5);
Expand Down Expand Up @@ -173,7 +174,8 @@ describe('request lib', () => {
expect(hook.error).toBe(errorResponse);
});

it('persists while a request is in-flight', async () => {
// FLAKY: https://github.com/elastic/kibana/issues/42563
it.skip('persists while a request is in-flight', async () => {
initUseRequest({ ...errorRequest });
await wait(5);
hook.sendRequest();
Expand Down Expand Up @@ -204,7 +206,8 @@ describe('request lib', () => {
expect(hook.data).toBe(successResponse.data);
});

it('is undefined when the request fails', async () => {
// FLAKY: https://github.com/elastic/kibana/issues/42562
it.skip('is undefined when the request fails', async () => {
initUseRequest({ ...errorRequest });
await wait(10);
expect(hook.isLoading).toBe(false);
Expand Down

0 comments on commit 8697967

Please sign in to comment.