Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust compat entry for Nemo and bump version #38

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

thofma
Copy link
Contributor

@thofma thofma commented Jan 4, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40127ab) 94.56% compared to head (4c2e1ee) 94.56%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files          15       15           
  Lines        1250     1250           
=======================================
  Hits         1182     1182           
  Misses         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ederc
Copy link
Collaborator

ederc commented Jan 4, 2024

@thofma Any ideas why the julia v1.6 tests fail? Is the (f, NARGS) = (AlgebraicSolving.submul, 4) output coming from the new Nemo version?

@thofma
Copy link
Contributor Author

thofma commented Jan 4, 2024

Hm, no clue. I will have a look tomorrow.

@thofma
Copy link
Contributor Author

thofma commented Jan 4, 2024

I just noticed that the documentation build pinned Nemo to 0.36.*, which is rather old. Let's see what happens now.

@thofma
Copy link
Contributor Author

thofma commented Jan 4, 2024

OK, I will have to adjust a few things tomorrow.

@ederc
Copy link
Collaborator

ederc commented Jan 4, 2024

OK, thanks, let me know if I can help you tomorrow.

@thofma thofma force-pushed the patch-2 branch 2 times, most recently from 27f9246 to 55f6b4e Compare January 4, 2024 21:24
@thofma thofma marked this pull request as draft January 4, 2024 21:27
@thofma
Copy link
Contributor Author

thofma commented Jan 4, 2024

I think I got everything working now. But I just noticed something about the printing, which we should fix now in Nemo. So let's put this on hold for a moment.

@thofma thofma marked this pull request as ready for review January 4, 2024 21:35
@thofma
Copy link
Contributor Author

thofma commented Jan 4, 2024

Ignore my previous comment. I just had to add an export statement here. Everything should be good to go now. Sorry for the confusion.

@ederc ederc merged commit bf742aa into algebraic-solving:main Jan 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants