Fix bug on variables permutation, when additional variables #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ederc
reviewed
Feb 28, 2024
Useless mention of step length Co-authored-by: ederc <ederc@mathematik.uni-kl.de>
|
@rprebet Thank you very much for your PR. I just made the test a bit more robust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reordering the variables in the output of msolve moves additional variables from the end to the beginning, while we want to ignore their values when isolating.
This caused an "index out of range" when pairing the isolated values and the corresponding variables, because we do not isolate values of additional variables. This happens for the system [x^2-1,y^2] for example, so I added it to the tests.
This is my first pull request ever, I hope I've done things right.