Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use par files to execute targets #15

Closed
wants to merge 2 commits into from

Conversation

prebeta
Copy link

@prebeta prebeta commented Mar 3, 2020

In order to ensure an encapsulated execution environment, we can use par files here to ensure that things work properly here in all our environments. We ran into issues where the locally installed version of pip was leaking into the piptool.py script and caused build breakages.

https://app.asana.com/0/0/1164576901785385/f

@prebeta prebeta closed this Mar 3, 2020
@prebeta prebeta deleted the tonyliang-use-par-files branch March 3, 2020 02:02
@prebeta prebeta restored the tonyliang-use-par-files branch March 3, 2020 02:03
@ali5h
Copy link
Owner

ali5h commented Mar 3, 2020

thank you, fyi, par files are not a good option for a public repo, they are basically binary files checked into repo, and updating them is not straight forward. we specifically removed par files because of this

@ali5h
Copy link
Owner

ali5h commented Mar 3, 2020

check this too bazelbuild/rules_python#184

@prebeta
Copy link
Author

prebeta commented Mar 3, 2020

Thanks for the context! I accidentally opened the PR on the wrong repository.

I agree that having to manage checked-in binaries is not an ideal solution and it's cleaner to directly execute on the source code, but some old installations of pip seem to leak into the execution environment here and cause import issues.

I'll maintain this code in our own repo for now.

@prebeta prebeta deleted the tonyliang-use-par-files branch March 3, 2020 18:31
@prebeta prebeta restored the tonyliang-use-par-files branch March 3, 2020 18:42
@prebeta prebeta deleted the tonyliang-use-par-files branch March 3, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants