Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for pip failure to perform editable install with --user #1813

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

acezen
Copy link
Collaborator

@acezen acezen commented Jul 7, 2022

What do these changes do?

PEP517 implemented recently in pip does not allow editable install in user site-packages. Add a workaround to support install with editable mode with --user

Related issue number

See discussion here pypa/pip#7953

@acezen acezen requested review from yecol and sighingnow July 7, 2022 07:08
@codecov-commenter
Copy link

Codecov Report

Merging #1813 (cfb0b6a) into main (889e003) will decrease coverage by 32.93%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1813       +/-   ##
===========================================
- Coverage   73.01%   40.07%   -32.94%     
===========================================
  Files          89       89               
  Lines        9801     9801               
===========================================
- Hits         7156     3928     -3228     
- Misses       2645     5873     +3228     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.30%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.16%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-95.66%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.00%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.57%) ⬇️
python/graphscope/tests/unittest/test_context.py 0.00% <0.00%> (-81.04%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 889e003...cfb0b6a. Read the comment docs.

@sighingnow sighingnow merged commit a675598 into alibaba:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants