Add K8s version query function through Tongyi Lingma analysis #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
利用通义灵码分析代码存在的问题，同时自动给出优化建议。（边界条件处理、异常处理）
owenwang2020
requested review from
johnlanni,
WeixinX,
CH3CHO and
SpecialYang
as code owners
|
|
|
这个PR是解决的什么问题，有对应issue吗？ |
owenwang2020
changed the title
|
Add K8s version query function through Tongyi Lingma analysis |
johnlanni
requested changes
Jul 23, 2024
| QueryParams parseParameters(absl::string_view data, size_t start, | ||
| bool decode_params) { | ||
| QueryParams params; | ||
| class QueryParams { |
| @@ -52,11 +52,16 @@ var ( | |||
| "Total invalid ingresses known to pilot.", | |||
| monitoring.WithLabels(clusterTag, invalidType), | |||
| ) | |||
|
|
|||
| queryK8sVersionFail = monitoring.NewSum( | |||
| @@ -81,6 +163,45 @@ func NetworkingIngressAvailable(client kube.Client) bool { | |||
| return runningVersion.AtLeast(version118) | |||
| } | |||
|
|
|||
| func NetworkingIngressAvailable(client kube.Client, retryOptions ...RetryOption) bool { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews