[metric] refact summary with better algorithm (#767)

* [metric] refact summary with better algorithm * fix msvc
alibaba · Sep 9, 2024 · 81a1866 · 81a1866
1 parent 7207de8
commit 81a1866
Show file tree

Hide file tree

Showing 8 changed files with 646 additions and 679 deletions.
diff --git a/include/ylt/metric/detail/ckms_quantiles.hpp b/include/ylt/metric/detail/ckms_quantiles.hpp
diff --git a/include/ylt/metric/detail/time_window_quantiles.hpp b/include/ylt/metric/detail/time_window_quantiles.hpp
diff --git a/include/ylt/metric/metric.hpp b/include/ylt/metric/metric.hpp
@@ -166,19 +166,6 @@ class metric_t {
   virtual void serialize_to_json(std::string& str) {}
 #endif
 
-  // only for summary
-  virtual async_simple::coro::Lazy<void> serialize_async(std::string& out) {
-    co_return;
-  }
-
-#ifdef CINATRA_ENABLE_METRIC_JSON
-  // only for summary
-  virtual async_simple::coro::Lazy<void> serialize_to_json_async(
-      std::string& out) {
-    co_return;
-  }
-#endif
-
   template <typename T>
   T* as() {
     return dynamic_cast<T*>(this);

diff --git a/include/ylt/metric/metric_manager.hpp b/include/ylt/metric/metric_manager.hpp
@@ -28,14 +28,8 @@ class manager_helper {
       const std::vector<std::shared_ptr<metric_t>>& metrics) {
     std::string str;
     for (auto& m : metrics) {
-      if (m->metric_type() == MetricType::Summary) {
-        async_simple::coro::syncAwait(m->serialize_async(str));
-      }
-      else {
-        m->serialize(str);
-      }
+      m->serialize(str);
     }
-
     return str;
   }
 
@@ -49,13 +43,7 @@ class manager_helper {
     str.append("[");
     for (auto& m : metrics) {
       size_t start = str.size();
-      if (m->metric_type() == MetricType::Summary) {
-        async_simple::coro::syncAwait(m->serialize_to_json_async(str));
-      }
-      else {
-        m->serialize_to_json(str);
-      }
-
+      m->serialize_to_json(str);
       if (str.size() > start)
         str.append(",");
     }