Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bin] meshroom_batch: Save the graph once it has been all set up and resolved #2095

Merged
merged 1 commit into from
Jul 3, 2023

Commits on Jun 30, 2023

  1. [bin] meshroom_batch: Save graph once it has been all set up and reso…

    …lved
    
    If the "save" argument has been provided, the graph should be saved
    outside of the `GraphModificatioǹ event, once it has been set up entirely
    and resolved.
    
    When it is saved within the `GraphModification`, UIDs are not yet
    available.
    
    This does not cause any issue for the rest of the execution if the graph
    is to be computed locally, since the UIDs will be computed right
    after (but the UIDs will still never be written in the project file).
    However, when submitting the graph to a renderfarm, the project file is
    loaded again. If it does not contain any UID:
     - all the nodes will present the `UidConflict` compatibility issue
     - key errors will be raised when trying to apply the links between nodes
    since they contain direct references to UIDs, which cannot be resolved as
    they are not present in the project file.
    cbentejac committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    1f75cca View commit details
    Browse the repository at this point in the history