Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scikit-learn 1.0 breaks builds #454

Closed
aaronreidsmith opened this issue Sep 24, 2021 · 5 comments · Fixed by #455
Closed

scikit-learn 1.0 breaks builds #454

aaronreidsmith opened this issue Sep 24, 2021 · 5 comments · Fixed by #455
Assignees

Comments

@aaronreidsmith
Copy link
Member

aaronreidsmith commented Sep 24, 2021

Describe the bug

scikit learn 1.0 was released this morning and is breaking our builds. This issue is for tracking work around getting tests to pass with scikit-learn 1.0

To Reproduce

make bdist_wheel

Versions

See the Install Requirements step here: https://github.com/alkaline-ml/pmdarima/runs/3700467105?check_suite_focus=true

Expected Behavior

pmdarima passes tests

Actual Behavior

pmdarima does not pass tests

Additional Context

No response

@Zahlii
Copy link

Zahlii commented Sep 24, 2021

Can confirm that the exact same bug also happens in our testing pipeline build atop on pmdarima with the exact same reason.

@Zahlii
Copy link

Zahlii commented Sep 24, 2021

TBH I think this is a bug in scikit-learn itself; here is a workaround I found

image

@aaronreidsmith
Copy link
Member Author

I think #455 should fix this without relying on a sklearn release

@microprediction
Copy link

Noticed this too. I'll try your patch.

@aaronreidsmith
Copy link
Member Author

This should be fixed in version 1.8.3 which went out today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants