Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Implement strategy from scikit-learn/scikit-learn#20506 #455

Merged
merged 10 commits into from
Sep 24, 2021

Conversation

aaronreidsmith
Copy link
Member

@aaronreidsmith aaronreidsmith commented Sep 24, 2021

Description

According to scikit-learn/scikit-learn#20506 and scikit-learn/scikit-learn#21144 (comment), it seems if_delegate_has_method is deprecated in favor of available_if. This is an attempt to switch to available_if

Fixes #454

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change

How Has This Been Tested?

  • Hoping tests pass on CI/CD (having trouble with local env currently 🤔 )

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aaronreidsmith aaronreidsmith changed the title [WIP] Implement strategy from https://github.com/scikit-learn/scikit-learn/issues/20506 [WIP] Implement strategy from scikit-learn/scikit-learn#20506 Sep 24, 2021
@aaronreidsmith aaronreidsmith marked this pull request as draft September 24, 2021 16:19
@aaronreidsmith aaronreidsmith changed the title [WIP] Implement strategy from scikit-learn/scikit-learn#20506 [MRG] Implement strategy from scikit-learn/scikit-learn#20506 Sep 24, 2021
@aaronreidsmith aaronreidsmith marked this pull request as ready for review September 24, 2021 16:38
@microprediction
Copy link

I'm tracking this here so adding myself to the thread in case I can be useful.

Copy link
Member

@tgsmith61591 tgsmith61591 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing this so quickly. A+ code

pmdarima/compat/sklearn.py Outdated Show resolved Hide resolved
@tgsmith61591 tgsmith61591 changed the title [MRG] Implement strategy from scikit-learn/scikit-learn#20506 [MRG+1] Implement strategy from scikit-learn/scikit-learn#20506 Sep 24, 2021
@aaronreidsmith aaronreidsmith merged commit 38755d3 into master Sep 24, 2021
@aaronreidsmith aaronreidsmith deleted the fix-sklearn-issues branch September 24, 2021 20:20
@microprediction
Copy link

Thank you. Thank you.

@ahgraber
Copy link

This has not been pushed to conda-forge yet. Are there any blockers preventing the conda-forge update?

@aaronreidsmith
Copy link
Member Author

We do not manage the Conda deploys, unfortunately. See this repo and this PR for tracking the Conda deployment

@ahgraber
Copy link

Thanks for the link to the conda side :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scikit-learn 1.0 breaks builds
4 participants